Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLT menu development for 14_0_X (10/N) [14_1_X] #46049

Merged
merged 2 commits into from
Sep 20, 2024
Merged

HLT menu development for 14_0_X (10/N) [14_1_X] #46049

merged 2 commits into from
Sep 20, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Sep 19, 2024 •
edited
Loading

backport of #46048

PR description:

Development of HLT menus for CMSSW_14_0_X (branch CMSSW_14_1_X).

  • This is the PR for the CMSSW_14_1_X branch, which will then be backported down to 14_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).
  • These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released, and target the 2024 HIon and PRef data-taking as well as the first pp menu for 2025.

This update includes the integration of the following JIRA tickets:

  • CMSHLT-3296 [TSG] Remove unused Paths of the Special table
  • CMSHLT-3298 [TSG] Remove suppression of warnings and errors from HLT MessageLogger for hltOnlineBeamSpot
  • CMSHLT-3303 [EXO] Add missing hltIter2MergedForDisplaced from HLTMonitor event content
  • CMSHLT-3310 [TSG] Update to 2024 eras in TSG tests
  • CMSHLT-3306 [HIon/DQM] Review of HIDQM EventContent (HI Run 2024)
  • CMSHLT-3307 [BRIL] Update "LumiScan" offline menu (post Run2024G)
  • CMSHLT-3329 [Egamma/PF] Fix mismatch of EB and EE recHits in supercluster producer modules
  • CMSHLT-3284 [HIon/TRK] Move to Pixel-Alpaka modules in the HIon menu
  • CMSHLT-3309 [DQM] Update DeltaR matching cut for hltPixelTracksSoACompareGPUvsCPU and hltSiPixelTracksSoACompareGPUvsCPUPPOnAA
  • CMSHLT-3323 [HIon] Muon Triggers for pp Reference Run 2024
  • CMSHLT-3332 [DQM] Fix inconsistent module labels for HLTDQMPixelReconstruction vs HLTDQMPixelReconstructionPPOnAA

In addition, the following changes are included:

  • c8466d4 update of L1T PRef menu in TSG GTs to L1Menu_CollisionsPPRef2024_v0_0_2_xml

PR validation:

TSG Integration tests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

backport of #46048 to the 2024 HIon production cycle (CMSSW_14_1_X)

@mmusich
HLT menu development for 14_0_X (branch for 14_1_X)
78858b6 
These updates correspond to the changes accumulated in the 14_0_X release cycle after the "V1.4" (last) menu for the 2024 pp data-taking period was released.
This update includes the integration of the following JIRA tickets:

- [CMSHLT-3296](https://its.cern.ch/jira/browse/CMSHLT-3296) [TSG] Remove unused Paths of the Special table
- [CMSHLT-3298](https://its.cern.ch/jira/browse/CMSHLT-3298) [TSG] Remove suppression of warnings and errors from HLT MessageLogger for hltOnlineBeamSpot
- [CMSHLT-3303](https://its.cern.ch/jira/browse/CMSHLT-3303) [EXO] Add missing hltIter2MergedForDisplaced from HLTMonitor event content
- [CMSHLT-3310](https://its.cern.ch/jira/browse/CMSHLT-3310) [TSG] Update to 2024 eras in TSG tests
- [CMSHLT-3306](https://its.cern.ch/jira/browse/CMSHLT-3306) [HIon/DQM] Review of HIDQM EventContent (HI Run 2024)
- [CMSHLT-3307](https://its.cern.ch/jira/browse/CMSHLT-3307) [BRIL] Update "LumiScan" offline menu (post Run2024G)
- [CMSHLT-3329](https://its.cern.ch/jira/browse/CMSHLT-3329) [Egamma/PF]  Fix mismatch of EB and EE recHits in supercluster producer modules
- [CMSHLT-3284](https://its.cern.ch/jira/browse/CMSHLT-3284) [HIon/TRK] Move to Pixel-Alpaka modules in the HIon menu
- [CMSHLT-3309](https://its.cern.ch/jira/browse/CMSHLT-3309) [DQM] Update DeltaR matching cut for hltPixelTracksSoACompareGPUvsCPU and hltSiPixelTracksSoACompareGPUvsCPUPPOnAA
- [CMSHLT-3323](https://its.cern.ch/jira/browse/CMSHLT-3323) [HIon] Muon Triggers for pp Reference Run 2024
- [CMSHLT-3332](https://its.cern.ch/jira/browse/CMSHLT-3332) [DQM] Fix inconsistent module labels for HLTDQMPixelReconstruction vs HLTDQMPixelReconstructionPPOnAA
@mmusich
update of L1T PRef menu in TSG GTs to L1Menu_CollisionsPPRef2024_v0_0…
c8466d4 
…_2_xml
@cmsbuild cmsbuild added this to the CMSSW_14_1_X milestone Sep 19, 2024
@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024 •
edited
Loading

A new Pull Request was created by @mmusich for CMSSW_14_1_X.

It involves the following packages:

  • Configuration/HLT (hlt)
  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @fabiocos, @missirol, @silviodonato this is something you requested to watch as well.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 19, 2024 •
edited
Loading

cms-bot internal usage

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

enable gpu

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Size: This PR adds an extra 792KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c9fae2/41613/summary.html
COMMIT: c8466d4
CMSSW: CMSSW_14_1_X_2024-09-18-2300/el8_amd64_gcc12
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/46049/41613/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 84 differences found in the comparisons
  • DQMHistoTests: Total files compared: 44
  • DQMHistoTests: Total histograms compared: 3330887
  • DQMHistoTests: Total failures: 5434
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3325433
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 43 files compared)
  • Checked 191 log files, 161 edm output root files, 44 DQM output files
  • TriggerResults: no differences found

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 7
  • DQMHistoTests: Total histograms compared: 53003
  • DQMHistoTests: Total failures: 95
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 52908
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 6 files compared)
  • Checked 24 log files, 30 edm output root files, 7 DQM output files
  • TriggerResults: no differences found

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

+hlt

@mmusich
Copy link
Contributor Author

mmusich commented Sep 19, 2024

type hlt-int

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d88ba97 into cms-sw:CMSSW_14_1_X Sep 20, 2024
12 checks passed
@mmusich mmusich deleted the HLTdevelopment140X_for141X branch September 20, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved hlt-integration orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_14_1_X
Development

Successfully merging this pull request may close these issues.
3 participants
@mmusich @cmsbuild @mandrenguyen